Add config option for event groups and stream buffers by kar-rahul-aws · Pull Request #994 · FreeRTOS/FreeRTOS-Kernel

kar-rahul-aws · 2024-02-14T19:35:48Z

Description

This PR adds config option for event group and stream buffer functionality.

Set configUSE_STREAM_BUFFERS = 1 to enable stream buffers.
Set configUSE_EVENT_GROUPS = 1 to enable event groups.

Test Steps

MPU demo on STM32H743ZI builds and runs successfully.

Checklist:

I have tested my changes. No regression in existing tests.
I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ompilers

… compilers

codecov · 2024-02-14T19:44:48Z

Codecov Report

Attention: Patch coverage is 82.38342% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 93.00%. Comparing base (39dbff7) to head (cea8ec8).

Files	Patch %	Lines
event_groups.c	82.38%	10 Missing and 24 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files           6        6           
  Lines        3200     3200           
  Branches      879      879           
=======================================
  Hits         2976     2976           
  Misses        111      111           
  Partials      113      113

Flag	Coverage Δ
unittests	`93.00% <82.38%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kstribrnAmzn · 2024-03-15T18:15:27Z

Why are there no testing details for this change? You changes to event_groups.c has less than 90% coverage. Are you planning on adding unit test changes here?

kar-rahul-aws · 2024-03-16T07:48:36Z

I will add the unit test coverage for the file event_groups.c once this PR is merged.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>

sonarqubecloud · 2024-03-27T08:36:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

* Add IPv6 Demo (FreeRTOS#937) * Add demo changes * Update kernel and library paths * Update main.c * Run uncrustify * Fix spell checker * CI check file headers update * Add IPv6/v4 UDP echo server with zero copy/non-zero copy versions * Add VS proj file changes to include the UDP echo sample code * readme update --------- Co-authored-by: Tony Josi <tonyjosi@amazon.com> * Update Backward Compatibility Flag (FreeRTOS#954) * Update Backward Compatibility Flag * Update FreeRTOS_GetUDPPayloadBuffer_ByIPType * Update FreeRTOS_IPStart to FreeRTOS_IPInit_Multi * Update Application APIs * Remove ipconfigCOMPATIBLE_WITH_SINGLE * Update Static Lib files (FreeRTOS#956) * Update Static Lib files * making vApplicationIPNetworkEventHook backward compatible in demos * Update CI check file headers --------- Co-authored-by: Tony Josi <tonyjosi@amazon.com> * Add WinPCap NetworkInterface Changes (FreeRTOS#958) * Update winpcap network interface * Run uncrustify * Update function to include NetworkInterface_t parameters * Adding compatibility for xApplicationDNSQueryHook with latest dev branch for old demos (FreeRTOS#957) * adding compatibility for xApplicationDNSQueryHook with latest dev branch * adding tcp echo server source * removing unused sub demos * fix build issues (FreeRTOS#969) * Update demo to latest +TCP dev/IPv6_integration (FreeRTOS#978) * remove macro namings * rename sin_addr to sin_address.ulIP_IPv4 for ipv6 demo * replace in6addr_any with FreeRTOS_in6addr_any * replace mainCREATE_UDP_ECHO_SERVER_TASK with mainCREATE_UDP_ECHO_TASKS_SINGLE * handle removal of sin_addr macro to sin_address.ulIP_IPv4 * updating +TCP repo to latest dev/IPv6_integration * minor update to more clear code * more sin_addr to sin_address.ulIP_IPv4 replacements * fix makefiles for qemu and posix demos * review feedback changes * Update FreeRTOS-Plus-TCP for RC2 * Change from PR (FreeRTOS#994) * Update FreeRTOS-Plus-TCP for RC2 * Update copyright * Ignore WinPCap for files header check failure. * Update checker * Update manifest * Point manifest to latest commit * Fix Spell-checker * Update doxygen * Update xApplicationDHCPHook for backward compatibility (FreeRTOS#999) * Update xApplicationDHCPHook for backward compatability * Update IPv6 * Update VisualStudio Static Project files * Update pxEndPoint error (FreeRTOS#1002) * Update IPv6 demo ReadMe (FreeRTOS#1004) * Update ReadMe * Update setup requirement * Update UDP demo info * Update comment * TCP demo changes post build separation (FreeRTOS#1011) * adding sin_family to dest adddr for FreeRTOS_sendto * updating FreeRTOS_bind to input sin_family post build separation changes * updating FreeRTOS_connect to input sin_family post build separation changes * minor fix * updating copyright year * updating file headers * updating +TCP submodule * updating file headers * updating file headers * updating manifest file to have latest +TCP submodule hash * Fix issue with posix demo while running with ipconfigIPv4_BACKWARD_COMPATIBLE enabled for +TCP stack (FreeRTOS#1027) * Update the submodule pointer to IPv6 main * Update manifest with latest TCP commit * Update file checker exception * Ignore Visual studio project file from file header checker --------- Co-authored-by: Tony Josi <tonyjosi@amazon.com>

kar-rahul-aws and others added 8 commits February 13, 2024 11:27

Add configUSE_EVENT_GROUPS in source files

4c23c0b

Merge branch 'FreeRTOS:main' into update_mpu_wrappers

8ec3080

Add configUSE_EVENT_GROUPS macro in MPU wrapper files

7720244

Add configUSE_EVENT_GROUPS macro in MPU port files for GCC and RVDS c…

4462fa1

…ompilers

Fix Formatting

f74cc70

Add configUSE_STREAM_BUFFERS in source files

57d6dba

Add configUSE_STREAM_BUFFERS macro in MPU wrapper files

3db6620

Add configUSE_STREAM_BUFFERS macro in MPU port files for GCC and RVDS…

334394e

… compilers

kar-rahul-aws requested a review from a team as a code owner February 14, 2024 19:35

kar-rahul-aws added 2 commits February 27, 2024 12:57

Merge branch 'main' into update_mpu_wrappers

b8e26bc

Merge branch 'main' into update_mpu_wrappers

aecd502

kar-rahul-aws marked this pull request as draft March 11, 2024 10:26

Update FreeRTOS.h post latest commit

547ba87

kar-rahul-aws marked this pull request as ready for review March 11, 2024 10:33

Update the ARM_CRx_MPU Port to account for the new configuration changes

0780657

joshzarr previously approved these changes Mar 15, 2024

View reviewed changes

paulbartell previously approved these changes Mar 15, 2024

View reviewed changes

kar-rahul-aws and others added 2 commits March 18, 2024 12:02

Merge branch 'main' into update_mpu_wrappers

248d03e

Formatting suggestions

8305bb9

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>

aggarg dismissed stale reviews from joshzarr and paulbartell via 8305bb9 March 18, 2024 07:22

aggarg previously approved these changes Mar 18, 2024

View reviewed changes

joshzarr previously approved these changes Mar 20, 2024

View reviewed changes

Merge branch 'main' into update_mpu_wrappers

655ba88

kar-rahul-aws dismissed stale reviews from joshzarr and aggarg via 655ba88 March 26, 2024 06:11

aggarg previously approved these changes Mar 26, 2024

View reviewed changes

Code review suggestions

3bf9afe

kar-rahul-aws dismissed aggarg’s stale review via 3bf9afe March 26, 2024 09:43

ActoryOu approved these changes Mar 26, 2024

View reviewed changes

kar-rahul-aws and others added 2 commits March 27, 2024 09:31

Merge branch 'main' into update_mpu_wrappers

566eb67

Merge branch 'main' into update_mpu_wrappers

da3d608

aggarg approved these changes Mar 27, 2024

View reviewed changes

Merge branch 'main' into update_mpu_wrappers

cea8ec8

shubnil approved these changes Mar 27, 2024

View reviewed changes

kar-rahul-aws merged commit e8289df into FreeRTOS:main Mar 27, 2024

kar-rahul-aws deleted the update_mpu_wrappers branch March 27, 2024 09:20

Navigation Menu

Uh oh!

Add config option for event groups and stream buffers - #994

Add config option for event groups and stream buffers#994
kar-rahul-aws merged 19 commits into
FreeRTOS:mainfrom
kar-rahul-aws:update_mpu_wrappers

kar-rahul-aws commented Feb 14, 2024

Uh oh!

codecov Bot commented Feb 14, 2024 •

edited

Loading

Uh oh!

kstribrnAmzn commented Mar 15, 2024

Uh oh!

kar-rahul-aws commented Mar 16, 2024 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Mar 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

kar-rahul-aws commented Feb 14, 2024

Description

Test Steps

Checklist:

Uh oh!

codecov Bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kstribrnAmzn commented Mar 15, 2024

Uh oh!

kar-rahul-aws commented Mar 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Mar 27, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov Bot commented Feb 14, 2024 •

edited

Loading

kar-rahul-aws commented Mar 16, 2024 •

edited

Loading