Open
ディスプレイ全体の翻訳に対応する#540
Conversation
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error when selecting display for translation
Support display/monitor capture with DISPLAY__<index> naming scheme
Dec 15, 2025
Owner
|
IProcessInfoStoreに対象がモニターかどうか判定するプロパティ追加して利用して。 |
…ng checks Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Contributor
Author
変更内容:
コミット: 257c22f |
Freeesia
reviewed
Sep 23, 2026
Freeesia
marked this pull request as ready for review
September 23, 2026 12:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
DisplayNameを設定名として翻訳を開始します。master 取り込みと修正
CaptureHelper.CreateItemForMonitorを呼び、選択した項目と表示名・サイズが一致する候補が1台だけなら採用します。対象判定の整理
DISPLAY__<番号>で保存した設定は自動移行しません。ICaptureModule.StartCaptureに渡されたハンドルをIsWindowとGetMonitorInfoで検証し、キャプチャー方式を選びます。無効なハンドルはエラーにします。IProcessInfoStore.IsMonitorを削除し、モニターも保持するMainWindowHandleをTargetHandleに改名しました。プラグイン向けインターフェイスの破壊的変更です。レビュー指摘への対応
if/elseにまとめました。確認状況
git diff --check:問題なし。ConfigurePluginParamOptionsTests:3件すべて成功しました。c8b22a29では GitHub Actions の .NET Core Package と .NET Core Desktop がともに成功しました。--no-restore -p:BuildProjectReferences=falseビルドが警告・エラーなしで成功しました。--no-restore -p:BuildProjectReferences=falseビルドが成功し、ソリューション全体の--no-restoreビルドはテストプロジェクトのproject.assets.json不足で失敗しました。Fixes #539