OrcaRouterをアプリバンドルから除外 - #707
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Closes #706
master の同梱方式を確認
master の
Plugins/WindowTranslator.Plugins.projは、同梱・非同梱をプロジェクト一覧で選別せず、WindowTranslator.Plugin.*\\*.csprojを含む@(DistributionProject)全件にRestore・Pack・Publishを実行します。同梱可否は各プラグインの
IsPublishableで決まります。IsPublishable=true)IsPublishable=false)IsPublishable=trueだったため、アプリバンドルのPublish対象でした.NET SDK の
Microsoft.NET.Publish.targetsでも、PublishターゲットはIsPublishable == 'true'の条件付きであることを確認しました。変更内容
Plugins/WindowTranslator.Plugins.projは master の既存方式へ戻すIsPublishableをfalseに変更IsPackable=trueは維持し、NuGetパッケージおよびプラグインストアからの配布は維持docs/README.mdの翻訳モジュール表にOrcaRouterのメリット・デメリットを追記docs/TranslateModule.mdとdocs/TranslateModule.en.mdに、利用方法・メリット・デメリット・推奨用途を追記確認
Plugins/WindowTranslator.Plugins.projの master との差分はありませんIsPublishable=false、IsPackable=trueを MSBuild 評価で確認git diff --check成功IsTestProject未設定のため、実際のテスト実行がスキップされたproject.assets.json不足で未実行