Repository navigation
LvArray update. - #1410
Merged
Merged
LvArray update.#1410
Conversation
corbett5
force-pushed
the
corbett/lvarray-0.2.0
branch
from
April 30, 2021 06:24
0ec4807 to
3eb9d31
Compare
rrsettgast
approved these changes
Apr 30, 2021
| { | ||
| m_componentVolumeShift.resize( NC ); | ||
| m_componentVolumeShift.setValues< serialPolicy >( 0.0 ); | ||
| m_componentVolumeShift.zero(); |
Contributor
There was a problem hiding this comment.
I like this a lot better 😃
corbett5
commented
May 4, 2021
| subRegion.getReference< array1d< real64 > >( FlowSolverBase::viewKeyStruct::deltaPressureString() ); | ||
|
|
||
| forAll< serialPolicy >( subRegion.size(), [&] ( localIndex const k ) | ||
| forAll< serialPolicy >( subRegion.size(), [=, &contactRelation] ( localIndex const k ) |
Contributor
Author
There was a problem hiding this comment.
@CusiniM this is the bug I mentioned to you.
Collaborator
There was a problem hiding this comment.
yeah, I had seen this and corrected it in my PR but it does not seem to be the only one...
corbett5
force-pushed
the
corbett/lvarray-0.2.0
branch
from
May 6, 2021 06:37
3eb9d31 to
17e6983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOS-DEV/LvArray#231
GEOS-DEV/GEOSX_PTP#28