docs: Compositional fluid model documentation - #3713
Merged
Merged
Conversation
dkachuma
marked this pull request as ready for review
August 27, 2026 14:30
dkachuma
requested review from
OmarDuran,
bd713,
jafranc,
jhuang2601,
joshua-white and
rrsettgast
as code owners
August 27, 2026 14:30
jhuang2601
approved these changes
Aug 27, 2026
Co-authored-by: Jian Huang <53012159+jhuang2601@users.noreply.github.com>
Contributor
|
@jafranc @joshua-white @OmarDuran |
jafranc
approved these changes
Aug 28, 2026
jafranc
left a comment
Contributor
There was a problem hiding this comment.
Kudos 👏 on such a delicat task of being succint but offering enough organized information to understand all implementation choice.
Few cosmetic suggestions to have homogene notations
Contributor
|
Needs code owner review from @OmarDuran , @bd713 , @joshua-white and/or @rrsettgast and we're ready to merge |
OmarDuran
reviewed
Sep 2, 2026
OmarDuran
reviewed
Sep 2, 2026
OmarDuran
approved these changes
Sep 2, 2026
OmarDuran
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I left two minor suggestions.
Contributor
|
@dkachuma Please address the comments from @jafranc and @OmarDuran, and this will be ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds complete documentation for the compositional fluid models that have been added.