Conversation
- normalizing ALMSinglePhase to be a PoromechanicsConformingFractures and not a SinglePhasePoromechanics anymore (as done for LM) - moving up `faceNodalArea` and `faceIntegral` to ContactSolverBase - moving up constexpr maxNumNodes - temp patching `hasStabilization/getStabilizationName` while waiting for bubble to reframe as Stabilization
jafranc
requested review from
OmarDuran,
castelletto1,
frankfeifan,
jhuang2601 and
rrsettgast
as code owners
July 23, 2026 08:39
jafranc
marked this pull request as draft
July 23, 2026 08:42
…sal-01-thermalALM
3 tasks
…sal-01-thermalALM
…com/GEOS-DEV/GEOS into jafranc/feat/proposal-01-thermalALM
jhuang2601
marked this pull request as ready for review
September 25, 2026 16:19
jhuang2601
requested review from
dkachuma,
joshua-white and
tjb-ltk
as code owners
September 25, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes refactoring ALM into a contact policy of the shared
PoromechanicsConformingFracturestemplate, so LM and ALM share one assembly path instead of duplicating it.Make MGR/coupling-type support explicit, not silent:
GEOS_MGR_STRATEGY_NOT_SUPPORTED()macro so a solver variant with no real MGR recipe yet errors loudly instead of silently reusing the wrong one — temporary, until a proper recipe is written and tested (left aside forSinglePhaseReservoirAndWells/CoupledReservoirAndWellsBaseto keep this PR focused on ALM).Fit ALM into the poromechanics hierarchy:
SinglePhasePoromechanicsConformingFracturesALMto derive fromPoromechanicsConformingFracturesinstead ofSinglePhasePoromechanicsdirectly (mirrors what LM already does).faceNodalArea/faceIntegraland themaxNumNodesconstant up toContactSolverBase.Restore the multiphase variants on top of the unified base:
MultiphasePoromechanicsConformingFractures(LM) reactivated and brought up to the current base-class API — real implementation, not a stub.MultiphasePoromechanicsConformingFracturesALMreactivated forSequentialcoupling.FullyImplicitremains explicitly unsupported for multiphase ALM (its force/pressure and mass/displacement coupling kernels are single-phase-only; to be done in follow up PR).TODO - Partial thermal support:
Warning
WIP - Proposal - DO NOT MERGE