Skip to content

fix: CUDA/HIP unit tests - #4130

Merged
victorapm merged 38 commits into
developfrom
fix/paludettomag1/cuda-tests
Sep 22, 2026
Merged

fix: CUDA/HIP unit tests#4130
victorapm merged 38 commits into
developfrom
fix/paludettomag1/cuda-tests

Conversation

@victorapm

@victorapm victorapm commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@victorapm victorapm self-assigned this Aug 28, 2026
@victorapm
victorapm requested a review from rrsettgast as a code owner August 28, 2026 14:24
@victorapm victorapm added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Aug 28, 2026
@victorapm victorapm added the flag: no rebaseline Does not require rebaseline label Aug 28, 2026
@victorapm victorapm added the ci: run code coverage enables running of the code coverage CI jobs label Aug 28, 2026
@victorapm victorapm added the ci: run device builds Allows to run the device (CUDA/HIP) builds label Aug 28, 2026
@victorapm
victorapm force-pushed the fix/paludettomag1/cuda-tests branch from c4edab0 to 3b2c026 Compare September 4, 2026 06:14
@victorapm victorapm mentioned this pull request Sep 5, 2026
Closed
5 tasks
@victorapm victorapm mentioned this pull request Sep 16, 2026
Merged
@victorapm

victorapm commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Needs code owner review from @MelReyCG, @OmarDuran, @bd713, @herve-gross, @jhuang2601 or @rrsettgast and we're ready to merge

OmarDuran
OmarDuran approved these changes Sep 22, 2026
View reviewed changes

@OmarDuran OmarDuran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you @victorapm

@victorapm
victorapm merged commit aec59de into develop Sep 22, 2026
22 checks passed
@victorapm
victorapm deleted the fix/paludettomag1/cuda-tests branch September 22, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmarDuran OmarDuran OmarDuran approved these changes
@joshua-white joshua-white joshua-white approved these changes
@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner
@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 is a code owner
@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin is a code owner
@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG is a code owner
@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma is a code owner
@bd713 bd713 Awaiting requested review from bd713 bd713 is a code owner
@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk is a code owner
@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 is a code owner
@jafranc jafranc Awaiting requested review from jafranc jafranc is a code owner
@cssherman cssherman Awaiting requested review from cssherman cssherman is a code owner
@andrea-borio andrea-borio Awaiting requested review from andrea-borio andrea-borio is a code owner
@herve-gross herve-gross Awaiting requested review from herve-gross herve-gross is a code owner

Assignees

@victorapm victorapm

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review flag: requires updated submodule(s)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@victorapm @OmarDuran @joshua-white @frankfeifan