Skip to content

Settup Github CI/CD with unit tests, mypy and linting checks #58

Description

@mlemayTTE

This PR is about updating GitHub CI (following initial settup #4) to include testing, linting and type checking since more Python code will be push from various teams following #54.

I propose to add:

  • testing with pytest, pytest-cov
  • type checking with mypy
  • linting. I am used to work with ruff, but the current python-package.yml include yapf. Does anyone have preferences?

Some open questions:

  • Do all the existing packages conform to typing and linting rules? What is the strategy if they do not (refactoring them before merging the PR, or removing them from checking and refactoring them later)?
  • What are Python versions supported? Is py3.8 still usefull?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions