refactor: create geos-pv package - #71
Merged
Merged
Conversation
paloma-martinez
requested changes
Apr 4, 2025
paloma-martinez
left a comment
Contributor
There was a problem hiding this comment.
There are some issues with the doc:
- see github action, there are some warnings
- automodule documentation : I tried to build the doc and had a lot of module import errors, can you check ?
alexbenedicto
approved these changes
Apr 10, 2025
alexbenedicto
self-requested a review
April 11, 2025 22:26
alexbenedicto
approved these changes
Apr 11, 2025
paloma-martinez
approved these changes
Apr 15, 2025
alexbenedicto
self-requested a review
April 15, 2025 17:25
alexbenedicto
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
Need to copy geos-posp/src/visu/PVUtils/* and geos-posp/src/visu/pythonViewUtils/* to avoid dependency of geos-posp to geos-pv. Will be removed once all Paraview plugins will be moved to geos-pv.