refactor: Reformat to respect ruff rules - #77
Merged
Merged
Conversation
alexbenedicto
approved these changes
Apr 7, 2025
alexbenedicto
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Maybe the choice between "typing" and "typing_extensions" libraries does not seem clear enough to me as to which one we should use. This can be discussed in another job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR #65 where ruff was included in the CI, refactor geos-hdf5-wrapper, geos-time-history and geos-xml-tools to honor ruff formatting rules.