Build hdf5 using CMake instead of Autogen - #243
Merged
Merged
Conversation
It avoids the spurious detection of the NDEBUG compilation flag by
CMake when importing the hdf5 package, see:
- Geos issue #2631
- hdf5 issue #3526
Contributor
Author
|
Remark: the failing builds on centos are linked to the detection of the hdf5 version in fesapi configuration and build. See F2I-Consulting/fesapi#326 |
This was referenced Sep 22, 2023
tbeltzun
reviewed
Sep 22, 2023
Contributor
wrtobin
approved these changes
Oct 10, 2023
wrtobin
left a comment
Contributor
There was a problem hiding this comment.
Working for the TPL build using quartz-clang-14, quartz-gcc-12, lassen-gcc-8-cuda-11, and lassen-clang-13-cuda-11 host-configs from the GEOS/develop/HEAD.
The quartz-gcc-12 build passes the integratedTests.
This was referenced Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids the spurious detection of the
NDEBUGcompilation flag byCMakewhen importing thehdf5package.As a side-effect, it will allow to test the
GEOSasserts in github-ci configs running inDebugmode.See:
GEOSissue Failing ci tests in Debug mode GEOS#2631hdf5issue Export of theNDEBUGflag inHDF5_DEFINITIONSCMake variable HDFGroup/hdf5#3526 (comment)I initially proposed this PR from a fork of the
TPLs but the ci fail due to missing authorization to connect to DockerHub.Previous discussion is available in the initial PR.
Closes #211, closes GEOS-DEV/GEOS#2631, closes HDFGroup/hdf5#3526.