Skip to content

fix(arma3server): remove quotes from around mod list in Arma3 server command line - #4288

Merged
dgibbs64 merged 2 commits into
GameServerManagers:developfrom
peejaybee:quote-fix
Nov 17, 2023
Merged

fix(arma3server): remove quotes from around mod list in Arma3 server command line#4288
dgibbs64 merged 2 commits into
GameServerManagers:developfrom
peejaybee:quote-fix

Conversation

@peejaybee

Copy link
Copy Markdown
Contributor

Description

This removes the quotes around the mod list as it appears in the command line parameters. This was breaking mod loading.

This reverts a change made by PR #3845, so I expect this may need discussion.

Fixes #4021

Type of change

  • Bug fix (a change which fixes an issue).

dependabot Bot and others added 2 commits August 20, 2023 19:14
Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 3.1 to 3.2.
- [Release notes](https://github.com/github/issue-labeler/releases)
- [Commits](github/issue-labeler@v3.1...v3.2)

---
updated-dependencies:
- dependency-name: github/issue-labeler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@peejaybee peejaybee changed the title fix: remove quotes from around mod list in Arma3 server command line fix(arma3server): remove quotes from around mod list in Arma3 server command line Aug 21, 2023
@peejaybee

Copy link
Copy Markdown
Contributor Author

Do I need to set the milestone it is asking for, or does someone else set that?

@dgibbs64

Copy link
Copy Markdown
Member

I set the milestones once I have reviewed the PR and picked the release the change will go in to :)

@dgibbs64
dgibbs64 force-pushed the develop branch 5 times, most recently from 891ed8f to ca184e3 Compare September 7, 2023 20:23
@dgibbs64 dgibbs64 added this to the v23.7.0 milestone Nov 17, 2023
@dgibbs64
dgibbs64 merged commit f80a1b6 into GameServerManagers:develop Nov 17, 2023
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants