fix: price impact net before - #516
Merged
Merged
Conversation
…peration netValuePriceImpact on an existing account was measured against the net value the operation leaves behind. A large withdrawal shrank that base and inflated the rate, and a full exit left none, so the rate silently became the routed-output one. It is now measured against the account's net value before the operation; the routed output stays the fallback where that base is not positive. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
PathLossRate gains absolutePriceImpact: the same loss the rates are drawn from, as a TokenAmount of the market's underlying, negative for a loss like the rates. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.