Review cleanups for main branch#220
Merged
Merged
Conversation
added 7 commits
July 8, 2026 10:07
Certify even-root bounds with direct downward rounding, complete Pow zero and fixpoint propagation, and restore sound Mult contraction at zero endpoints. Add focused regression coverage for each case.
Resolve dependencies from the requested component closure, use same-minor package compatibility, and suppress header auto-linking for CMake consumers. Make custom VIS regeneration explicit and validate it with package, consumer, and test-selection smoke checks.
Accept both the historical GIST_STATIC_LIBS spelling and the GECODE_GIST_STATIC_LIBS spelling in public headers. Cover both forms with preprocessing smoke tests.
Replace Bash-only substitutions and test operators in the Autoconf path. Run the custom VIS smoke test under dash and cover multiple VIS inputs.
Keep CMake and Autoconf test selection aligned, run the new package and macro smoke checks, and reject stale generated sources using the release toolchain. Regenerate the FlatZinc parser with the pinned Bison version.
Keep module ordering and Float classification deterministic, reject invalid release metadata, and parse exact changelog entries during tidy checks. Record the FlatZinc and Gist compatibility notes for 6.4.0.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Ignore the complete set of in-tree example executables without broad patterns, and restore the vendored Boost backup file as valid UTF-8 text.
360d863 to
6931d71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of clean-ups and fixes based on GPT 5.6 Sol Ultra review.