Skip to content

Tests for asset/snippets/test/ need to be refactored #2864

Description

@ahrarmonsur

The language repo migration for googleapis/nodejs-asset created the following PR:
#2856

The PR was blocked due to failing tests, which are all in one filetests/samples.test.js. The advice from @grayside to unblock the migration PR was to:

  • keep the tests in the migration
  • remove the workflow for the asset samples
  • create an issue capturing the follow-on work

The language maintainers are to:

  • refactor the tests into individual files corresponding to the sample
  • generate the workflow for asset/snippets again

This is captured in this conversation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: cloudassetIssues related to the Cloud Asset Inventory API.priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions