Skip to content

Removed the App Engine Redis sample - #1864

Merged
fhinkel merged 2 commits into
masterfrom
michaelawyu-patch-appengine-redis
Jun 8, 2020
Merged

fhinkel merged 2 commits into
masterfrom
michaelawyu-patch-appengine-redis

Conversation

@michaelawyu

@michaelawyu michaelawyu commented Jun 8, 2020 •

Copy link
Copy Markdown
Contributor

This sample is no longer featured in the documentation and has been replaced by the Memorystore for Redis + App Engine sample (/memorystore/redis).

See also cl/315371333.

Fixes #1690, #1691, #1800.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2020
@michaelawyu
michaelawyu requested review from ace-n and fhinkel June 8, 2020 23:06

@fhinkel fhinkel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kokoro files on GitHub need to be deleted, too.

@michaelawyu

michaelawyu commented Jun 8, 2020 •

Copy link
Copy Markdown
Contributor Author

My bad. The configs have been removed. @fhinkel

@fhinkel
fhinkel merged commit 2b101c2 into master Jun 8, 2020
@fhinkel
fhinkel deleted the michaelawyu-patch-appengine-redis branch November 5, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

appengine/redis: should be listening failed

3 participants