Skip to content

chore: delete storage transfer samples - #2165

Merged
fhinkel merged 2 commits into
GoogleCloudPlatform:masterfrom
tritone:delete-sts
Feb 16, 2021
Merged

fhinkel merged 2 commits into
GoogleCloudPlatform:masterfrom
tritone:delete-sts

Conversation

@tritone

@tritone tritone commented Feb 12, 2021

Copy link
Copy Markdown
Contributor

Reasons to delete:

  • Added in 2016 and not substantially updated since.
  • Region tags were never implemented in other languages or used in the docs.
  • Does not conform to current sample standards.
  • @JesseLovelace started a new set of updated, conforming samples for STS (Java and Python implemented/published so far).

Fixes #2148

@tritone
tritone requested a review from fhinkel as a code owner February 12, 2021 19:23
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2021
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Feb 12, 2021
@snippet-bot

snippet-bot Bot commented Feb 12, 2021 •

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@tritone

tritone commented Feb 12, 2021

Copy link
Copy Markdown
Contributor Author

@fhinkel is there something I missed as far as removing this from the CI?

@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2021
@fhinkel

fhinkel commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

I removed it from required tests. Did you send an internal CL to remove the job configs?

Comment thread CONTRIBUTING.md
1. Change directory to one of the sample folders, e.g. `datastore`.

cd storage-transfer/
cd datastore/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you.

@fhinkel fhinkel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@fhinkel
fhinkel merged commit 6955bf0 into GoogleCloudPlatform:master Feb 16, 2021
@tritone
tritone deleted the delete-sts branch February 16, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage-transfer: "before all" hook for "should create a storage transfer job" failed

3 participants