Skip to content

improvement: extend compute_hyperdisk_pool_create - #3826

Merged
gryczj merged 1 commit into
mainfrom
hyperdisk_pool_extension
Oct 9, 2024
Merged

improvement: extend compute_hyperdisk_pool_create#3826
gryczj merged 1 commit into
mainfrom
hyperdisk_pool_extension

Conversation

@gryczj

@gryczj gryczj commented Sep 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj
gryczj requested review from a team as code owners September 4, 2024 15:16
@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Sep 4, 2024
@gryczj gryczj self-assigned this Sep 4, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 4, 2024
@gryczj
gryczj force-pushed the hyperdisk_pool_extension branch from 81a1059 to b6ef4ed Compare September 4, 2024 15:18
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 4, 2024
@gryczj
gryczj force-pushed the hyperdisk_pool_extension branch 4 times, most recently from 321697b to 781a9f2 Compare September 16, 2024 11:59
@gryczj

gryczj commented Sep 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Please, check and merge after: #3868. Issues with tests need to be resolved first.

@gryczj
gryczj force-pushed the hyperdisk_pool_extension branch from 781a9f2 to 9cd4cb2 Compare September 20, 2024 11:11
@gryczj gryczj removed their assignment Sep 24, 2024
@gryczj
gryczj force-pushed the hyperdisk_pool_extension branch from 9cd4cb2 to ddbbfe0 Compare September 26, 2024 14:47
@gryczj
gryczj force-pushed the hyperdisk_pool_extension branch from ddbbfe0 to 26f4104 Compare October 3, 2024 18:41
@gryczj

gryczj commented Oct 3, 2024

Copy link
Copy Markdown
Contributor Author

Pipeline should be fixed after merging #3868

@gryczj
gryczj force-pushed the hyperdisk_pool_extension branch from 26f4104 to 2292350 Compare October 7, 2024 17:51
@gryczj
gryczj force-pushed the hyperdisk_pool_extension branch from 5d1a906 to ecbc172 Compare October 9, 2024 10:56
@gryczj
gryczj merged commit ca4d3b3 into main Oct 9, 2024
@gryczj
gryczj deleted the hyperdisk_pool_extension branch October 9, 2024 10:58
@TetyanaYahodska TetyanaYahodska mentioned this pull request Oct 19, 2024
Merged
3 of 11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@subfuzion subfuzion subfuzion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gryczj @subfuzion @kokoro-team