Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I wanted to modify this program for some of my use cases, and decided it would be easy enough to implement these cases as CLI options. As such, this is a sizeable PR with quite a bit of refactoring; I'm completely open to different naming, etc., if you have opinions.
I've added CLI options:
The first two are self-explanatory, and the preamble option is an extensible solution for users that wish to change or alter symbols from
unicodemathsymbols.txt(or use their own "macros") without relying on the program author to make such a change.All the existing tests pass, and I've added a few tests for the CLI options as well.