Skip to content

eCLM-ParFlow: account for soil ice when receiving ParFlow water content (#126, #123) #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-poll merged 5 commits into from
Sep 4, 2026
Merged

eCLM-ParFlow: account for soil ice when receiving ParFlow water content (#126, #123) #127

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9d7307
reduce log-file output
s-poll Jun 11, 2026
1206290
eCLM-ParFlow: account for soil ice when receiving ParFlow water content
s-poll Aug 11, 2026
477ef4b
Revert "reduce log-file output"
s-poll Aug 17, 2026
31e938a
eCLM-ParFlow: add in-code comment for soil ice partitioning
s-poll Sep 1, 2026
6e9fc7d
Merge branch 'master' into dev-h2osoiice
s-poll Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/clm5/biogeophys/SoilWaterMovementMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,20 +1488,24 @@ subroutine soilwater_parflow(bounds, num_hydrologyc, &

associate(&
smp_l => soilstate_inst%smp_l_col , & ! Input: [real(r8) (:,:) ] soil matrix potential [mm]
h2osoi_liq => waterstate_inst%h2osoi_liq_col , & ! Input: [real(r8) (:,:) ] liquid water (kg/m2)
h2osoi_liq => waterstate_inst%h2osoi_liq_col , & ! Output: [real(r8) (:,:) ] liquid water (kg/m2)
h2osoi_ice => waterstate_inst%h2osoi_ice_col , & ! Output: [real(r8) (:,:) ] ice lens (kg/m2)
smpmin => soilstate_inst%smpmin_col , & ! Input: [real(r8) (:) ] restriction for min of soil potential (mm)
pfl_h2osoi_liq => waterstate_inst%pfl_h2osoi_liq_col , & ! Input: [real(r8) (:,:) ] ParFlow soil water (mm)
pfl_psi => waterstate_inst%pfl_psi_col & ! Input: [real(r8) (:,:) ] ParFlow pressure head (mm)
) ! end associate statement


! COUP_OAS_PFL
! TODO
! Exchange of soil water and pressure head between ParFlow and eCLM
! ParFlow has no ice phase, so that the received water it the total water content.
! Keep the ice what PhaseChanged diagnosed earlier in the time step and
! attribute the remainder to liquid, so that liq and ice matches the received total.
do fc = 1, num_hydrologyc
c = filter_hydrologyc(fc)

do j = 1, nlevgrnd
h2osoi_liq(c,j) = pfl_h2osoi_liq(c,j)
h2osoi_ice(c,j) = min(h2osoi_ice(c,j), pfl_h2osoi_liq(c,j))
h2osoi_liq(c,j) = max(0._r8, pfl_h2osoi_liq(c,j) - h2osoi_ice(c,j))
Comment thread
kvrigor marked this conversation as resolved.
if (pfl_psi(c,j) <= 0) then
smp_l(c,j) = max(smpmin(c), pfl_psi(c,j))
end if
Expand Down
Loading