eCLM-ParFlow: Route impervious urban runoff into ParFlow - #138
Draft
s-poll wants to merge 2 commits into
Draft
Conversation
- bugfix: pfl_psi/pfl_h2osoi_liq were distributed over filter_soilc, but eCLM run over filter_hydrologyc, leading to soilwater_parflow wrote nan into h2osoi_liq for pervious road - distribute over filter_nolakec testing col%hydrologically_active, the predicate filterMod uses for filter_hydrologyc, originally leading to undefined TWS
- impervious urban runoff left the domain as river runoff without entering ParFlow - route it into ParFlow layer 1 - zeroed qflx_surf/qflx_qrgwl and write it to qflx_drain as for every other coupled column
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #133, which fixes the urban state distribution. This adds the runoff routing that was originally part of it.
This is one special case of the general runoff / overland-flow treatment discussed in #136. Open for discussion whether eCLM should pre-classify infiltration versus runoff.
Change
Roof, wall and impervious-road runoff left the domain as river runoff and never entered ParFlow's budget. It is now routed into ParFlow layer 1. Both runoff terms are zeroed where they are read so the water is not counted twice, and the exchange is booked to
qflx_drainas for every other coupled column.More information
Can be found in #133