Skip to content

OMI: Observation input dr: Array of Length 2 in observation file #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjokella merged 2 commits into from
Apr 27, 2026
Merged

OMI: Observation input dr: Array of Length 2 in observation file #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dedd9ed
observation input `dr` to length 2
jjokella Apr 16, 2026
6feb2f9
docs: update docs for `dr`
jjokella Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions docs/users_guide/running_tsmp_pdaf/input_obs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,14 +273,9 @@ Each of the CLM observations is snapped to the nearest CLM grid cell
based on the given `lon`, `lat` and the snapping distance `dr` which
should be smaller than the minimum grid cell size.

**Attention (non-OMI)** This variable should have a length of `2` (one
snapping distance in longitude direction and another snapping distance
in latitude direction).

**Attention (OMI)** in OMI `dr` is currently read as `dim=dim_obs` and
used as length `1` (only the first element, used for both longitude
direction and latitude direction). See [PDAF with
OMI](omi:tsmp-pdaf-with-pdaf-omi).
This variable should have a length of `2` (one snapping distance in
longitude direction and another snapping distance in latitude
direction).

(obs:files:clm:typeclm)=
#### type_clm ####
Expand Down
26 changes: 11 additions & 15 deletions docs/users_guide/running_tsmp_pdaf/tsmp_pdaf_omi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,25 +19,21 @@ If questions arise contact ewerdwalbesloh@geod.uni-bonn.de
The reader `read_obs_nc_type` expects the following variables in each
observation file:

| NetCDF name | Type | Required? |
|--------------|----------------------------------------------------|-----------------|
| `dim_obs` | dimension | yes |
| `obs_clm` | `REAL(dim_obs)` | yes |
| `type_clm` | `CHARACTER(20)(dim_obs)` | yes |
| `lon` | `REAL(dim_obs)` | yes |
| `lat` | `REAL(dim_obs)` | yes |
| `layer` | `INTEGER(dim_obs)` | yes |
| `dr` | read from netCDF: `REAL(dim_obs)`, used: `REAL(1)` | yes |
| `obserr_clm` | `REAL(dim_obs)` | if `multierr=1` |
| `obscov_clm` | `REAL(dim_obs,dim_obs)` | if `multierr=2` |
| NetCDF name | Type | Required? |
|--------------|--------------------------|-----------------|
| `dim_obs` | dimension | yes |
| `obs_clm` | `REAL(dim_obs)` | yes |
| `type_clm` | `CHARACTER(20)(dim_obs)` | yes |
| `lon` | `REAL(dim_obs)` | yes |
| `lat` | `REAL(dim_obs)` | yes |
| `layer` | `INTEGER(dim_obs)` | yes |
| `dr` | `REAL(2)` | yes |
| `obserr_clm` | `REAL(dim_obs)` | if `multierr=1` |
| `obscov_clm` | `REAL(dim_obs,dim_obs)` | if `multierr=2` |

Files follow the naming convention `<obs_filename>.<NNNNN>`
(five-digit zero-padded PDAF step).

**Note** on `dr`: For non-OMI, this array has length `2`, but in OMI
it is read in `mod_read_obs` as length `dim_obs` and then only the
first element is used.

The [`type_clm`](obs:files:clm:typeclm) field must be homogeneous
within a file - a file containing GRACE observations cannot
simultaneously contain SM or C observations.
2 changes: 1 addition & 1 deletion interface/framework/mod_read_obs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ subroutine read_obs_nc_type(current_observation_filename, &
allocate(layer_obs_g(dim_obs))

if(allocated(dr_obs_g)) deallocate(dr_obs_g)
allocate(dr_obs_g(dim_obs))
allocate(dr_obs_g(2))

call check(nf90_get_var(ncid, clmobs_varid, obs_g))

Expand Down
10 changes: 5 additions & 5 deletions interface/framework/obs_SM_pdafomi.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ SUBROUTINE init_dim_obs_SM(step, dim_obs)
if(allocated(lat_obs)) deallocate(lat_obs)
allocate(lat_obs(dim_obs))
if(allocated(dr_obs)) deallocate(dr_obs)
allocate(dr_obs(dim_obs))
allocate(dr_obs(2))
if(allocated(layer_obs)) deallocate(layer_obs)
allocate(layer_obs(dim_obs))
if(multierr==1) then
Expand All @@ -362,7 +362,7 @@ SUBROUTINE init_dim_obs_SM(step, dim_obs)
if(multierr==1) call mpi_bcast(obserr, dim_obs, MPI_DOUBLE_PRECISION, 0, comm_filter, ierror)
call mpi_bcast(lon_obs, dim_obs, MPI_DOUBLE_PRECISION, 0, comm_filter, ierror)
call mpi_bcast(lat_obs, dim_obs, MPI_DOUBLE_PRECISION, 0, comm_filter, ierror)
call mpi_bcast(dr_obs, dim_obs, MPI_DOUBLE_PRECISION, 0, comm_filter, ierror)
call mpi_bcast(dr_obs, 2 , MPI_DOUBLE_PRECISION, 0, comm_filter, ierror)
call mpi_bcast(layer_obs, dim_obs, MPI_INTEGER, 0, comm_filter, ierror)


Expand Down Expand Up @@ -434,7 +434,7 @@ SUBROUTINE init_dim_obs_SM(step, dim_obs)

! Assigning observations to grid cells according to
! snapping distance or index arrays
if(((is_use_dr).and.(deltax<=dr_obs(1)).and.(deltay<=dr_obs(1))).or. &
if(((is_use_dr).and.(deltax<=dr_obs(1)).and.(deltay<=dr_obs(2))).or. &
((.not. is_use_dr).and.(longxy_obs(i) == longxy(cnt)) .and. &
(latixy_obs(i) == latixy(cnt)))) then

Expand Down Expand Up @@ -619,7 +619,7 @@ SUBROUTINE init_dim_obs_SM(step, dim_obs)
deltay = abs(lat(g)-lat_obs(i))
end if

if(((is_use_dr).and.(deltax<=dr_obs(1)).and.(deltay<=dr_obs(1))).or. &
if(((is_use_dr).and.(deltax<=dr_obs(1)).and.(deltay<=dr_obs(2))).or. &
((.not. is_use_dr).and.(longxy_obs(i) == longxy(g-begg+1)) .and. &
(latixy_obs(i) == latixy(g-begg+1)))) then
#ifdef CLMFIVE
Expand Down Expand Up @@ -712,7 +712,7 @@ SUBROUTINE init_dim_obs_SM(step, dim_obs)
deltay = abs(lat(g)-lat_obs(i))
end if

if(((is_use_dr).and.(deltax<=dr_obs(1)).and.(deltay<=dr_obs(1))).or. &
if(((is_use_dr).and.(deltax<=dr_obs(1)).and.(deltay<=dr_obs(2))).or. &
((.not. is_use_dr).and.(longxy_obs(i) == longxy(g-begg+1)) .and. &
(latixy_obs(i) == latixy(g-begg+1)))) then
! if haversine formula in distance calculation, the coordinates have to be converted to radians
Expand Down