Audit crypto/util/assert/url for Node 24 + Haxe 4 - #229
Merged
Conversation
Drop Haxe 3 conditionals, add missing Node 24 APIs (KeyObject, X509, MIMEType, CallTracker, URLPattern, argon2/KEM, parseArgs, etc.), and narrow avoidable Dynamic usage with remaining gaps marked TODO(section-4). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#if haxe4/js.htmlArrayBuffer fallbacks across crypto, util, assert, and url packages.KeyObject/X509Certificate, key generation/KEM/argon2, one-shothash/sign/verify, utilparseArgs/MIMEType/styleText/etc.,assert.CallTracker,URLPattern/fileURLToPathBuffer,querystring.unescapeBuffer.DynamicwithAny/ tighter types; leave remaining soft spots as// TODO(section-4): ….crypto.subtle/crypto.webcrypto(typed to stdjs.html.*); no separatejs.node.webcryptopackage.Test plan
haxe build.hxmlwith Haxe 4.0.0haxe build.hxmlwith current HaxeRemaining TODOs
js.html.CryptogenerateKeyPair*overloads / encodingsKeyObject.asymmetricKeyDetails/parseArgsgenericscallbackify/promisifytypingsMade with Cursor