Skip to content

Wire TLSSocket to crypto.X509Certificate #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinresol merged 1 commit into from
Jul 14, 2026
Merged

Wire TLSSocket to crypto.X509Certificate #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/js/node/tls/TLSSocket.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@ package js.node.tls;

import haxe.Constraints.Function;
import haxe.extern.EitherType;
import js.lib.Error;
import js.node.Buffer;
import js.node.Tls.TlsClientOptionsBase;
import js.node.Tls.TlsServerOptionsBase;
import js.node.crypto.X509Certificate;
import js.node.events.EventEmitter.Event;
import js.node.tls.SecureContext.SecureContextOptions;
import js.lib.Error;

/**
Enumeration of events emitted by `TLSSocket` objects in addition to its parent class events.
Expand Down Expand Up @@ -203,16 +204,16 @@ extern class TLSSocket extends js.node.net.Socket {
/**
Returns the peer certificate as an `X509Certificate` object.

// TODO(section-3): type against crypto.X509Certificate once crypto audit exposes it
If there is no peer certificate, or the socket has been destroyed, `null` is returned.
**/
function getPeerX509Certificate():Any;
function getPeerX509Certificate():Null<X509Certificate>;

/**
Returns the local certificate as an `X509Certificate` object.

// TODO(section-3): type against crypto.X509Certificate once crypto audit exposes it
If there is no local certificate, or the socket has been destroyed, `null` is returned.
**/
function getX509Certificate():Any;
function getX509Certificate():Null<X509Certificate>;

/**
Initiate TLS renegotiation process.
Expand Down
Loading