Skip to content

chore(repo): register the loki and clickhouse PR scopes - #482

Merged
HugoRCD merged 1 commit into
mainfrom
chore/register-adapter-scopes
Aug 1, 2026
Merged

chore(repo): register the loki and clickhouse PR scopes#482
HugoRCD merged 1 commit into
mainfrom
chore/register-adapter-scopes

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Why

Validate PR title reads the scope list from the base branch's workflow file, so a PR that introduces a new subsystem cannot register its own scope — the check runs against main's copy and rejects the title before the PR can merge.

Both adapter PRs fail on exactly this:

Unknown scope "loki" found in pull request title "feat(loki): add the Grafana Loki drain adapter".
Scope must match one of: ai, axiom, bench, … workers.

What

Registers clickhouse and loki in both lists, alphabetically:

  • .github/workflows/semantic-pull-request.yml
  • .github/pull_request_template.md

Merging this unblocks #480 (Loki) and #481 (ClickHouse), whose own copies of these hunks are removed in a follow-up push so they don't conflict.

Follow-up

.agents/skills/create-adapter/SKILL.md step 7 currently says to add the scope "in the same PR". That is unworkable for the title check. Worth amending to "in a preceding PR, or omit the scope from the title" — happy to do that separately.

Summary by CodeRabbit

  • Chores
    • Added ClickHouse and Loki as valid pull request scopes.
    • Updated pull request templates and title validation to support the new scopes.

`semantic-pull-request.yml` validates a PR title against the scope list as
it exists on the base branch, so a PR that introduces a new subsystem
cannot register its own scope — the check reads main's copy and rejects the
title. #480 and #481 both fail on exactly that.

Registering the two scopes ahead of the adapters unblocks them. Worth
noting in `.agents/skills/create-adapter/SKILL.md`, which currently tells
you to add the scope "in the same PR".
@changeset-bot

changeset-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 54ce3ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
evlog-docs Ready Ready Preview, v0 Aug 1, 2026 4:41pm
evlog-render-lab Ready Ready Preview Aug 1, 2026 4:41pm
evlog-telemetry Ready Ready Preview Aug 1, 2026 4:41pm
just-use-evlog Ready Ready Preview Aug 1, 2026 4:41pm

Request Review

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bdf7cfaf-6b42-43d8-8c7e-99c93416dcd4

📥 Commits

Reviewing files that changed from the base of the PR and between 35431c2 and 54ce3ae.

📒 Files selected for processing (2)
  • .github/pull_request_template.md
  • .github/workflows/semantic-pull-request.yml

📝 Walkthrough

Walkthrough

The pull request template and semantic title validator now support clickhouse and loki scopes for drain adapter changes.

Changes

Pull request scope support

Layer / File(s) Summary
Scope declarations and validation
.github/pull_request_template.md, .github/workflows/semantic-pull-request.yml
The template lists clickhouse and loki scopes. The semantic pull request workflow accepts both scopes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes registering the loki and clickhouse repository scopes.
Description check ✅ Passed The description explains the problem, changes, affected files, and follow-up work, although it does not use the template checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/register-adapter-scopes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 1, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@evlog/cli@482
npm i https://pkg.pr.new/evlog@482
npm i https://pkg.pr.new/@evlog/nuxthub@482
npm i https://pkg.pr.new/@evlog/telemetry@482

commit: 54ce3ae

@HugoRCD HugoRCD self-assigned this Aug 1, 2026
@HugoRCD
HugoRCD merged commit 4b021d7 into main Aug 1, 2026
23 checks passed
@HugoRCD
HugoRCD deleted the chore/register-adapter-scopes branch August 1, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant