Skip to content

Ildcl unique f02 - #7152

Merged
Amstutz merged 4 commits into
ILIAS-eLearning:trunkfrom
sz-tik:ildcl-unique-f02
Mar 14, 2024
Merged

Ildcl unique f02#7152
Amstutz merged 4 commits into
ILIAS-eLearning:trunkfrom
sz-tik:ildcl-unique-f02

Conversation

@sz-tik

@sz-tik sz-tik commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Uniqueness check of number and of text field when editing a data record or adding a new data record corrected.
Some improvements made to the code concerning basic field operations of the DC.

@dsstrassner

Copy link
Copy Markdown
Contributor

Hi @sz-tik, if you post a Mantis Issue URL, I can label this as Bug fix. Until then, this is an Improvement.

@sz-tik

sz-tik commented Mar 12, 2024

Copy link
Copy Markdown
Contributor Author

@dsstrassner
Hi Dennis,

this code fixed the uniqueness check for field type integer and text.
The following error has led to the uniqueness of all field types being checked
"mantis number 30758: Formula doesn't test uniqueness right away."

Possibly corrected checks for the other field types, esp. the formula field, will follow.

f02 also includes the changes from f01, so f01 is actually obsolete. Sry.

@Amstutz

Amstutz commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

I looked through it, and discussed some questions through discord with @sz-tik . Thx a lot for improving this!

@Amstutz
Amstutz merged commit 2c78d5e into ILIAS-eLearning:trunk Mar 14, 2024
@sz-tik sz-tik mentioned this pull request Mar 15, 2024
@sz-tik
sz-tik deleted the ildcl-unique-f02 branch March 15, 2024 17:14
@iszmais

iszmais commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

@sz-tik @Amstutz ,

I stumbled upon this during the testing of https://testrail.ilias.de/index.php?/tests/view/77632 since regex and length are no longer checked for ILIAS 10 on text fields.

Obviously, because the check is removed here.
Normally I would assume this to be a bug, but since this is explicitly removed here (and I could not find any reasoning why) i just want to double-check what the intention of this was.

Greetings,
@iszmais

@iszmais

iszmais commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

@sz-tik @Amstutz FIY.

I restored some of the removed code here since it removed required validations: #9426

Please let me know if this contradicts any of your conceptions.

Greetings,
@iszmais

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants