T&A 44764: Fixes end datetime of availability period in test settings being rese…#9309
Merged
Merged
Conversation
…t to 01.01.1970 upon saving
Contributor
Author
|
Already reviewed by @thojou. |
Contributor
|
Hi @matheuszych Thank you very much for the PR! Please remove the array deconstruction here, and just use the corresponding keys as it was before. Straight forward is better: With your change I need twice as much time to read and understand the same thing. Thank you very much and best, |
Contributor
Author
|
Hello @kergomard Best regards |
kergomard
pushed a commit
that referenced
this pull request
Apr 7, 2025
… being rese… (#9309) * Fixes end datetime of availability period in test settings being reset to 01.01.1970 upon saving * Adds review changes
kergomard
pushed a commit
that referenced
this pull request
Apr 7, 2025
… being rese… (#9309) * Fixes end datetime of availability period in test settings being reset to 01.01.1970 upon saving * Adds review changes
Contributor
|
Thank you very much @matheuszych ! Merged and picked to ILIAS 10 and trunk. |
msalterhslu
pushed a commit
to HochschuleLuzern/ILIAS-HSLU
that referenced
this pull request
Jun 11, 2025
… being rese… (ILIAS-eLearning#9309) * Fixes end datetime of availability period in test settings being reset to 01.01.1970 upon saving * Adds review changes
olivabigyo
pushed a commit
to olivabigyo/ILIAS
that referenced
this pull request
Jan 27, 2026
… being rese… (ILIAS-eLearning#9309) * Fixes end datetime of availability period in test settings being reset to 01.01.1970 upon saving * Adds review changes
olivabigyo
pushed a commit
to HochschuleLuzern/ILIAS-HSLU
that referenced
this pull request
Apr 5, 2026
… being rese… (ILIAS-eLearning#9309) * Fixes end datetime of availability period in test settings being reset to 01.01.1970 upon saving * Adds review changes Jira: IL-537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mantis: 44764
The
activation_ending_timesetting in a test was always being overwritten with the date01.01.1970(timestamp 0). The error seems to be caused by never applying the data from the form.