Search: abandon advanced search#9404
Merged
smeyer-ilias merged 1 commit intoApr 23, 2025
Merged
Conversation
smeyer-ilias
approved these changes
Apr 23, 2025
smeyer-ilias
left a comment
Contributor
There was a problem hiding this comment.
Thanks @schmitz-ilias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Abandon Advanced Search, along with some clean up in Search.
I had to keep the classes around that do the actual searching (
ilAdvancedSearchandilLikeAdvancedSearch), because they are still used in Container filters, seeFilterManager. We should have a look at this again at some point along withilMetaDataSearch, since those classes still contain direct accesses to MetaData db tables, but that is not a super high priority.