Skip to content

UI/URLBuilder: Use correct type declaration for acquireParameter#9417

Merged
thibsy merged 1 commit into
ILIAS-eLearning:release_9from
mjansenDatabay:hotfix/9/urlbuilder-phpdoc-type
Apr 16, 2025
Merged

UI/URLBuilder: Use correct type declaration for acquireParameter#9417
thibsy merged 1 commit into
ILIAS-eLearning:release_9from
mjansenDatabay:hotfix/9/urlbuilder-phpdoc-type

Conversation

@mjansenDatabay

@mjansenDatabay mjansenDatabay commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

The current return type declaration in the PHPDoc comment results in false positives in SCA (e.g. in PHPStorm).

Bildschirmfoto vom 2025-04-16 13-43-42

With the change this PR suggests, calls to withParameter are not reported as "method not found" anymore.

@mjansenDatabay mjansenDatabay added improvement php Pull requests that update Php code labels Apr 16, 2025

@thibsy thibsy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@thibsy
thibsy merged commit 6b26918 into ILIAS-eLearning:release_9 Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants