chore: refresh dependencies to address security findings - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Synchronize and secure OpenChat's dependencies after auditing the monorepo. Apply semver-compatible dependency updates that eliminate all GCP server, web client, and MCP server production audit findings and remove all critical and low findings repository-wide; upgrade the dev-only vulnerable Vitest 2.x to 4.1.11 while preserving test compatibility; keep the mobile app on Expo SDK 54 for this low-risk shipping pass, align expo-updates with Expo Doctor's expected 29.0.20 patch, and do not force the separate Expo 57/React Navigation migration needed for the remaining mobile-only findings. Validate under Node 20, preserve the intentional monorepo Metro configuration, push via a feature branch/PR, and ensure CI passes. Remaining Expo 57 work is tracked as OpenChat-8qrh.
What Changed
expo-updatesto 29.0.20 in the mobile manifest and both lockfiles while retaining Expo SDK 54.Risk Assessment
✅ Low: The bounded manifest and lockfile refresh conforms to the stated dependency strategy: targeted production workspaces audit clean, repository-wide critical/low counts are zero, Expo remains on SDK 54 with expo-updates 29.0.20, and Metro configuration is unchanged.
Testing
No baseline, automated, manual, or evidence-producing checks completed, so the requested dependency-security refresh remains unverified in this test phase.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
apps/mobile/package-lock.json:29- The tracked standalone mobile lockfile was not synchronized with the manifest: its root dependency and resolved package remain on expo-updates 29.0.18. A Node 20 standalonenpm cifails because that version does not satisfy the required ~29.0.20 range. Regenerate apps/mobile/package-lock.json so standalone/EAS mobile installs are reproducible at 29.0.20.git diff --check bfe67477d26219592dcf5d27f063b20c48962a25..2ba3c2ae36069897c4fc00ebda54c30fef61cde8and targeted manifest/config diff inspectionnpx --yes -p node@20 -c 'node --version && npm --version && npm ci'using Node v20.20.2Node 20npm audit --omit=dev --workspace=apps/server --jsonNode 20npm audit --omit=dev --workspace=apps/web --jsonNode 20npm audit --omit=dev --workspace=apps/mcp-server --jsonNode 20 repository-widenpm audit --jsonNode 20node node_modules/vitest/vitest.mjs run apps/serverNode 20expo-doctor apps/mobileNode 20 Expo web export using the preservedapps/mobile/metro.config.js, followed by manual browser verification of the rendered login surface at 390×844Byte comparison ofapps/mobile/metro.config.jsagainst the base commitStandalone Node 20npm ci --ignore-scriptsusing copies ofapps/mobile/package.jsonandapps/mobile/package-lock.jsonRemoved generated dependency directories and Expo cache from the worktree; retained only dedicated evidence files🔧 Fix: Synchronize standalone mobile expo-updates lockfile
1 warning still open:
No test command completed before the phase ended.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.