DATA: Valid many-component compressed MetaIO fixture (ITK #6692) - #78
Merged
hjmjohnson merged 1 commit intoJul 23, 2026
Conversation
The existing rf_voltage ...fft1d_size_128.mha content link (bafkreigfnnwheantnltrycahox5r3agtmf4q2vfmbabrjx7rjs66iikozi) holds a truncated zlib stream: it decompresses to 119 bytes while its header declares 31 MET_FLOAT channels (124 bytes). The pre-#6692 MetaIO reader silently accepted the short read; the MetaIO 8c41a1d9 uncompression-result fix (ITK #6692) correctly rejects it. This blob is the same image re-encoded as a valid 124-byte compressed stream (the historically-delivered 119 bytes zero-padded to the declared size), so itkImageFileReaderManyComponentVectorTest reads a self-consistent file.
hjmjohnson
marked this pull request as ready for review
July 23, 2026 20:52
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Jul 23, 2026
The prior fixture's compressed stream was truncated (decompressed to 119 bytes while its header declares 31 MET_FLOAT channels = 124 bytes). The MetaIO 8c41a1d9 uncompression-result fix in this branch correctly rejects it, breaking itkImageFileReaderManyComponentVectorTest. Point the content link at the valid re-encoded blob published in InsightSoftwareConsortium/ITKTestingData#78.
dzenanz
reviewed
Jul 23, 2026
dzenanz
left a comment
Member
There was a problem hiding this comment.
Interesting that we had an invalid file in our regression test suite 😄
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Jul 23, 2026
The prior fixture's compressed stream was truncated (decompressed to 119 bytes while its header declares 31 MET_FLOAT channels = 124 bytes). The MetaIO 8c41a1d9 uncompression-result fix in this branch correctly rejects it, breaking itkImageFileReaderManyComponentVectorTest. Point the content link at the valid re-encoded blob published in InsightSoftwareConsortium/ITKTestingData#78.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a valid replacement blob for the many-component compressed MetaIO fixture used by
itkImageFileReaderManyComponentVectorTest, needed by ITK #6692 (MetaIO8c41a1d9vendor update).New CID:
bafkreifuvkmy4vvxyhxwcga5rvs3y75dwyt4bf3h6g2fyoxt3am5jqzbraWhy a new blob is needed
The existing content link (
bafkreigfnnwheantnltrycahox5r3agtmf4q2vfmbabrjx7rjs66iikozi) holds a truncated zlib stream: it decompresses to 119 bytes while the.mhaheader declares 31MET_FLOATchannels for a 1×1 image (124 bytes). 119 is not even a multiple of 4, so it cannot represent 31 floats.The pre-#6692 MetaIO reader silently accepted the short read (decompressing 119 bytes into a 124-byte buffer, leaving 5 bytes uninitialized, and returning success). The MetaIO
8c41a1d9fix (MET_PerformUncompressionnow reports its byte count and callers honour it — ITK #6575 B66) correctly rejects the truncated stream, which brokeitkImageFileReaderManyComponentVectorTeston ITK #6692.This blob is the same image re-encoded as a valid 124-byte compressed stream — the historically-delivered 119 bytes zero-padded to the declared size — so the reader consumes a self-consistent file. Verified: the stored blob's content hash equals its CID filename, and the file reads without exception under the #6692 MetaIO build.