Comparison using is when operands support __eq__ - #4335
Merged
Merged
Conversation
Comparison using 'is' when equivalence is not the same as identity
breuerfelix
requested review from
breuerfelix
and removed request for
breuerfelix
April 22, 2019 07:07
Collaborator
|
I changed base to dev, PR approved by me, you are totally right, here want to test for equality and not for identity ! |
Collaborator
|
@MatheusRV Absolutely true! Thank you for PRing this 馃槉 @breuerfelix Thank you Felix for approving this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparison using 'is' when equivalence is not the same as identity
When you compare two values using the is or is not operator, it is the object identities of the two values that is tested rather than their equality. If the class of either of the values in the comparison redefines equality then the is operator may return False even though the objects compare as equal. Equality is defined by the eq or, in Python2, cmp method. To compare two objects for equality, use the == or != operator instead.