Return Python array API compatible device objects from inspection namespace#2979
Open
antonwolfy wants to merge 4 commits into
Open
Return Python array API compatible device objects from inspection namespace#2979antonwolfy wants to merge 4 commits into
antonwolfy wants to merge 4 commits into
Conversation
…ata-API concept of devices
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2979/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev2=py313h509198e_8 ran successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array API inspection namespace (
__array_namespace_info__()) returned rawdpctl.SyclDeviceobjects fromdevices()anddefault_device(), while an array's.deviceattribute is adpnp.tensor.Devicewrapper.Because
Device.__eq__does not consider a bareSyclDeviceequal, the objects returned by the inspection API did not compare equal tox.device, which the Python array API standard requires:Changes
This PR updates
Info.devices()to return a tuple ofdpnp.tensor.Devicewrappers (built viaDevice.create_device), instead of a list of rawdpctl.SyclDeviceobjects. The wrappers carry the default cached queues for each root device, which is sufficient for the common cases.Additionally
Info.default_device()likewise now returns aDevicewrapper for consistency, sox.device,default_device(), and the elements ofdevices()all compare equal for the default device.