This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Refactoring ParforDiagnostics#130
Closed
1e-to wants to merge 0 commit into
Closed
Conversation
|
We need to make sure this PR is against the correct branch before we start merging it. I will test it once we know this issue is fixed. |
|
Too many changes got introduced as part of the porting process from pydppl to patched. We need to clean it up to see the actual changes @1e-to. |
PokhodenkoSA
suggested changes
Dec 4, 2020
PokhodenkoSA
left a comment
There was a problem hiding this comment.
Please, reset to branch patched and cherry-pick your commit. Then target the PR to patched.
Author
|
Reopen in #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be able to get "all_lines" to reuse it in our ExtendedParforDiagnostics to avoid code duplication.
Also now "dump" function is too complicated so this refactoring was made.