fix: support renaming repos - #100
Merged
Merged
Conversation
KRaffael
approved these changes
Aug 12, 2026
Contributor
|
🎉 This PR is included in version 0.8.5 🎉 The release is available on GitHub release and as container image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes repository renaming support in the
Repositoryreconciler. Previously, changingspec.nameon an already-trackedRepositorycaused the reconciler to look up the repo by its (new) desired name, get a 404 from GitHub, and create a brand-new duplicate repository — silently orphaning the original repo under its old name.getRepo()now prefers looking up the repository by its stable GitHub ID (Status.ID) viaGetRepositoryByID, falling back to name-based lookup only when no ID is stored or the ID lookup finds nothing. Once the current repository is resolved,r.GitHub.Resource.Nameis kept in sync with GitHub's actual current name (via the newupdateRecFieldsFromGitHubhelper, replacingupdateID), so that:mapper.RepoDiffers().EditRepositoryis called with the current (old) name in the URL path and the new name in the request body — matching GitHub's rename semantics (PATCH /repos/{owner}/{current-name}with{"name": "new-name"}).Type of Change
Checklist
make codegenRelated Issues