non-production update readme with targeting best practices - #139
Draft
omeedrj wants to merge 4 commits into
Draft
Conversation
…ADME with targeting best practices
…re 'active_support/core_ext' to spec_helper.rb
…age of activesupport's 'presence' method to get tests to not fail with activesupport 7.1.2
…ctivesupport/core_ext/object/blank in spec_helper.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Readme With Targeting Best Practices
Summary of Changes
spec_helper.rbto not useactivesupport'spresencemethod so it's compatible with7.1.2Update
There are some issues with activesupport 7.1.2 working with rspec, I'm going to leave this PR open in case anyone else wants to dig in. See this thread for details. See this other PR as well: #140.