Skip to content

chore(miner-ui): remove 3 dead exports only reachable from tests (emptyPortfolioQueueSummary, emptyLedgersSummary, defaultGovernorPauseState) #6187

Description

@JSONbored

Context

Three exported values in apps/loopover-miner-ui/src/lib/ have zero real (non-test) callers, confirmed via repo-wide search:

  • emptyPortfolioQueueSummarylib/portfolio-queue.ts:54
  • emptyLedgersSummarylib/ledgers.ts:21
  • defaultGovernorPauseStatelib/governor.ts:24

tsconfig.json has "noUnusedLocals": false, so nothing in the build catches this.

Requirements

  • Confirm via a fresh repo-wide search that all three have zero real (non-test) callers.
  • Remove each, along with any test that exists purely to exercise the removed export (keep tests for the surrounding module's real behavior).
  • If a genuine real use case exists for any of the three (e.g. a route's error/loading fallback state that should use one of these defaults but currently constructs its own inline default), wire it in instead of deleting — but only if a real current gap is found, not speculatively.

Deliverables

  • All 3 confirmed-dead exports removed (or wired into a genuine real call site if one is found).

Expected Outcome

No orphaned default/empty-state constants remain with zero real usage in apps/loopover-miner-ui/src/lib.

Links & Resources

  • apps/loopover-miner-ui/src/lib/portfolio-queue.ts:54, lib/ledgers.ts:21, lib/governor.ts:24

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions