Skip to content

docs(review): ops-wire.ts's comment claims the tunables_overrides/_shadow/override_audit D1 tables don't exist yet — they already do (#4879) #6195

Description

@JSONbored

Context

src/review/ops-wire.ts:26-30's header comment says the auto-tune/auto-apply config-mutation self-improve loop is deliberately unclosed because it "needs the tunables_overrides / _shadow / override_audit D1 tables (none of which exist in loopover's migrations yet)." This is stale: migrations/0047_self_improve_tunables.sql already creates all three tables (tunables_overrides at line 22, tunables_overrides_shadow at line 33, override_audit at line 44), and src/review/auto-apply.ts already implements the pure logic + D1 store against them (loadOverride/writeLiveOverride/deleteLiveOverride, loadShadowOverride/writeShadowOverride/deleteShadowOverride, recordOverrideAudit/listOverrideAudit, per the migration file's own header comment). The comment's premise — that the tables don't exist yet — is no longer true, even though the module remains correctly read-only for other reasons (the "careful soak/promote design" for actually closing the loop, which is a separate, real, larger gap tracked elsewhere).

Requirements

  • Update src/review/ops-wire.ts:26-30's comment to stop claiming the D1 tables don't exist — they do, as of #4879's migration 0047_self_improve_tunables.sql.
  • Keep the comment's correct, still-true point that this module remains deliberately read-only pending the soak/promote design — only the "tables don't exist yet" premise is stale, not the overall deferred-status conclusion.
  • No code behavior change — this is a comment-only fix.

Deliverables

  • src/review/ops-wire.ts:26-30's comment accurately reflects that the D1 tables already exist, while still correctly noting the loop-closing logic itself remains deferred.

Expected Outcome

A reader of this module's header comment isn't misled into thinking the D1 schema is the blocker, when the real remaining blocker is the soak/promote design.

Links & Resources

  • src/review/ops-wire.ts:26-30
  • migrations/0047_self_improve_tunables.sql:10-12,22,33,44
  • src/review/auto-apply.ts (the already-implemented pure logic + D1 store)

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions