Skip to content

Post a maintainer-tagging follow-up comment with screenshots for unrelated visual findings on PR close/merge #7372

Description

@JSONbored

Problem

`review.visual.bugAnalysis` (#7335 / #7348) already flags visual issues the AI vision reviewer spots that are unrelated to the PR's stated change, as advisory-only warnings in the unified review comment. They're easy to lose track of once the PR closes — nothing about them is actionable, and nobody is notified once the PR itself is done.

Ask

When a PR with recorded `visual_unrelated_issue_finding` advisory findings is merged OR closed (either outcome), post a new, standalone comment that:

  • @-mentions a configurable list of maintainers (see below)
  • Describes each unrelated finding and includes its before/after screenshot(s)
  • Is formatted so a maintainer can use GitHub's own "..." → "Reference in new issue" action directly on that comment to spin off a tracked issue with one click

Config-as-code

A new global-default + per-repo `.loopover.yml` field for the notify list — never hardcoded to a specific user. Absent/empty ⇒ falls back to the existing "maintainer" resolution already used elsewhere in the codebase (repo owner + `ADMIN_GITHUB_LOGINS`), not a literal username.

Scope

  • New optional screenshot-evidence field threaded through `AdvisoryFinding` → `persistAdvisory` so it survives from review-time to close-time
  • A DB reader for the latest persisted advisory for a PR (none exists today — `persistAdvisory` is currently write-only)
  • Hook into the `pull_request` `closed` webhook action (both merged and non-merged closes)
  • Idempotent (a marker so retried `closed` deliveries don't double-post)
  • Tests, docs, and `config/examples/loopover.full.yml` / `.loopover.yml.example` updates

Metadata

Metadata

Assignees

Labels

maintainer-onlyOwner-only work — yields no Gittensor points.orbGittensory Orb related - maintainer self-hosting analytics.visualUI/web visual work — owner-led, NOT for Gittensor contributors (extensions excepted)

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions