[Bug]: GraphQL openIssuesTotal counts open pull requests as issues

[dearsishs]

[Bug]: GraphQL openIssuesTotal counts open pull requests as issues

Summary

refreshRepoGithubTotals() stores repository.issues(states: OPEN).totalCount, which includes open PRs in GitHub’s GraphQL model. REST backfill already filters pull_request rows, but totals and GraphQL supplement do not.

Steps to reproduce

1. Sync a repo with open issues and open PRs (e.g. totals where issues.totalCount includes PR count).
2. Compare openIssuesTotal to REST issue-only count.

Expected behavior

openIssuesTotal reflects issues only, consistent with REST !issue.pull_request filtering.

Actual behavior

Total is inflated by open PR count; open-issue segments can stay partial and GraphQL supplement may upsert PRs as issues.

Impact

Incorrect sync completeness and polluted issue rows.

[dosubot]

I looked into this and the report appears to be based on a common misconception about GitHub's GraphQL API. In this codebase, the issues and pullRequests types are separate top-level connections in GitHub's GraphQL schema — unlike the REST /issues endpoint which conflates the two.

Looking at refreshRepoGithubTotals() in src/github/backfill.ts [1]:

repository(owner: "...", name: "...") {
  issues(states: OPEN) { totalCount }
  openPullRequests: pullRequests(states: OPEN) { totalCount }
  ...
}

The repository.issues(states: OPEN).totalCount field in GitHub's GraphQL API returns only issues — it does not include pull requests. This is different from the REST /repos/{owner}/{repo}/issues endpoint, which does mix issues and PRs (hence the !issue.pull_request filter at line 856–859) [2].

Similarly, the GittensoryOpenIssuesSupplement query at line 1069 queries issues(states: OPEN, first: 100) [3], which in GraphQL returns only issue nodes — not PRs.

TL;DR: The GraphQL issues connection is already issue-only. If you're seeing inflated counts, the cause is likely elsewhere — perhaps a stale snapshot, a race with the REST backfill, or an actual GitHub API inconsistency for the repo in question. Could you share the specific repo and the numbers you're comparing? That would help narrow down whether this is a data staleness issue or something else.

To reply, just mention @dosu.

---

Docs are dead. Just use Dosu.

[JSONbored]

Please do not game issues - this issue was opened 1 minute before it was linked, very clearly trying to game the points system.