You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
⚠️ Definition of Done: this issue must be completed in full, in a single PR. Do not split this
work across multiple PRs, and do not defer any Deliverable below to a follow-up issue. A PR that
satisfies only some of the Deliverables, stubs a required test, or leaves a checkbox
partially-done does NOT resolve this issue and will be closed.
Context
maybeApplyManifestPolicyGate in src/queue/processors.ts has two comments claiming it "pushes
ONLY the three enforceable policy findings onto the advisory":
The function's JSDoc, ~line 9318-9319.
An inline comment inside the function body, ~line 9341-9342.
and src/rules/advisory.ts's resolveConfiguredGateMode only treats exactly these two manifest_* codes as blockable under manifestPolicyGateMode — confirming two is the current,
correct count, not three.
Verified via git history: policyCodes originally held three entries — "manifest_blocked_path", "manifest_linked_issue_required", "manifest_missing_tests" —
matching "three" at the time. Commit 329af5a9 ("fix(config): stop documenting the retired
blockedPaths key as a live feature, #5304") correctly removed the dead "manifest_blocked_path"
string (it hadn't been emitted since the blockedPaths field was retired) but never updated the
two "three enforceable policy findings" comments that referenced the old count.
This is a pure comment-text mismatch with zero logic change — the same class of drift #5304 itself
fixed for the equivalent stale claims in .gittensory.yml.example and config/examples/gittensory.full.yml, just missed in this one function's own doc comments.
Requirements
Update both occurrences of "three enforceable policy findings" in maybeApplyManifestPolicyGate (the JSDoc and the inline comment) to say "two", matching the
actual policyCodes set.
Do not change policyCodes itself or any other logic in the function — this is a
comment-only fix.
maybeApplyManifestPolicyGate's JSDoc comment updated from "three" to "two enforceable
policy findings".
The matching inline comment inside the function body updated identically.
A grep across src/queue/processors.ts for the string "three enforceable" confirms zero
remaining occurrences after the fix (state this check was performed in the PR description).
All deliverables are required in this single PR.
Test Coverage Requirements
This is a comment-only change with no executable logic modified, so no new test is required. State
explicitly in the PR description that no test changes are needed because no behavior changed —
do not add a placeholder/stub test.
Expected Outcome
maybeApplyManifestPolicyGate's doc comments accurately describe the current two-code policyCodes set, matching what src/rules/advisory.ts's resolveConfiguredGateMode actually
enforces, instead of referencing a stale three-code count from before manifest_blocked_path was
retired.
Context
maybeApplyManifestPolicyGateinsrc/queue/processors.tshas two comments claiming it "pushesONLY the three enforceable policy findings onto the advisory":
The actual code only filters for two codes:
and
src/rules/advisory.ts'sresolveConfiguredGateModeonly treats exactly these twomanifest_*codes as blockable undermanifestPolicyGateMode— confirming two is the current,correct count, not three.
Verified via git history:
policyCodesoriginally held three entries —"manifest_blocked_path","manifest_linked_issue_required","manifest_missing_tests"—matching "three" at the time. Commit
329af5a9("fix(config): stop documenting the retiredblockedPaths key as a live feature, #5304") correctly removed the dead
"manifest_blocked_path"string (it hadn't been emitted since the
blockedPathsfield was retired) but never updated thetwo "three enforceable policy findings" comments that referenced the old count.
This is a pure comment-text mismatch with zero logic change — the same class of drift #5304 itself
fixed for the equivalent stale claims in
.gittensory.yml.exampleandconfig/examples/gittensory.full.yml, just missed in this one function's own doc comments.Requirements
maybeApplyManifestPolicyGate(the JSDoc and the inline comment) to say "two", matching theactual
policyCodesset.policyCodesitself or any other logic in the function — this is acomment-only fix.
.gittensory.yml.exampleorconfig/examples/gittensory.full.yml— fix(config): stop documenting the retired blockedPaths key as a live feature #5304 alreadyfixed those.
Deliverables
maybeApplyManifestPolicyGate's JSDoc comment updated from "three" to "two enforceablepolicy findings".
src/queue/processors.tsfor the string "three enforceable" confirms zeroremaining occurrences after the fix (state this check was performed in the PR description).
All deliverables are required in this single PR.
Test Coverage Requirements
This is a comment-only change with no executable logic modified, so no new test is required. State
explicitly in the PR description that no test changes are needed because no behavior changed —
do not add a placeholder/stub test.
Expected Outcome
maybeApplyManifestPolicyGate's doc comments accurately describe the current two-codepolicyCodesset, matching whatsrc/rules/advisory.ts'sresolveConfiguredGateModeactuallyenforces, instead of referencing a stale three-code count from before
manifest_blocked_pathwasretired.
Links & Resources
src/queue/processors.ts(maybeApplyManifestPolicyGate, ~lines 9318-9342)src/rules/advisory.ts:~1345-1360(resolveConfiguredGateMode, confirms two is correct)329af5a9/ fix(config): stop documenting the retired blockedPaths key as a live feature #5304 (removed the dead third code but missed these two comments)