Skip to content

verify: real-diff review on a clean non-guarded PR #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 1 commit into from
Closed

verify: real-diff review on a clean non-guarded PR #1067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/review/guardrail-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
const config = (await env.REVIEW_CONFIG.get(slug, "json")) as { hardGuardrailGlobs?: JsonValue } | null;
return asNonEmptyStringArray(config?.hardGuardrailGlobs) ?? DEFAULT_CRUCIAL_GUARDRAIL_GLOBS;
} catch {
return DEFAULT_CRUCIAL_GUARDRAIL_GLOBS;

Check warning on line 34 in src/review/guardrail-config.ts

View check run for this annotation

Deleted GitHub App / Gittensory Context

Missing test evidence 

Code changed without an obvious test file in this PR. Add focused tests or explain why existing coverage is sufficient.

Check notice on line 34 in src/review/guardrail-config.ts

View check run for this annotation

Deleted GitHub App / Gittensory Context

Issue discovery is disabled for this repo 

This repo is configured for direct contribution review rather than issue-discovery flow.

Check notice on line 34 in src/review/guardrail-config.ts

View check run for this annotation

Deleted GitHub App / Gittensory Context

Open PR queue is busy 

This repo has a busy open PR queue in the local Gittensory cache.

Check notice on line 34 in src/review/guardrail-config.ts

View check run for this annotation

Deleted GitHub App / Gittensory Context

PR author has maintainer association 

This PR appears to come from a maintainer-associated account.
}
}

// Note: the per-repo guardrail globs are operator tuning and live ONLY in the REVIEW_CONFIG KV (keyed by repo
// slug) — never committed here — so they can be retuned at runtime without a redeploy. This module is just the
// fail-safe reader + the conservative code-floor default.
Loading