fix(review): exclude ALL bot-owned checks (Gate + Context) — completes self-deadlock fix - #1105
Merged
Conversation
…it — completes the self-deadlock fix #1099 excluded only Gittensory Gate, but the bot posts TWO checks as in_progress while reviewing — Gittensory Gate AND Gittensory Context (app.ts:23-24). Counting Context re-created the exact same self-deadlock: green-CI PRs (e.g. metagraphed #1532, all real checks success/neutral) deferred forever as 'CI still running' because the bot waited on its own in_progress Context check. Generalize the exclusion to a BOT_OWNED_CHECK_NAMES set so the bot never waits on ANY check it posts itself. Test now asserts both in_progress bot checks are ignored -> ciState 'passed'.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 153 153
Lines 18554 18555 +1
Branches 6708 6708
=======================================
+ Hits 17588 17589 +1
Misses 408 408
Partials 558 558 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes #1099. That fix excluded only
Gittensory Gate, but the bot posts two checks asin_progresswhile reviewing —Gittensory GateandGittensory Context(app.ts:23-24). CountingContextre-created the identical self-deadlock: green-CI PRs (metagraphed #1532 — every real check success/neutral) deferred forever as 'CI still running'.Fix: generalize to a
BOT_OWNED_CHECK_NAMESset sofetchLiveCiAggregatenever waits on any check the bot posts itself. Test asserts both in_progress bot checks are ignored →passed. Full suite green (3492).