fix(agent): hold crucial/guarded PRs on reject (don't auto-close) - #1109
Merged
Conversation
…g (#hold-crucial-on-reject) Operator decision: a guarded/crucial PR (CI, the review engine, visual) must NEVER be auto-closed, even on a reject verdict — a hallucinated reject (the #1528 near-miss: diff-only false-positives) must not auto-close a good crucial PR. The owner verifies + closes/merges. The BULK (non-guarded) contributor PRs still auto-close one-shot on a bad verdict / conflict; only the small crucial set is held. Restores the guardrail check on willClose (reverts #1106's removal). Owner/automation PRs never close regardless.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 153 153
Lines 18557 18557
Branches 6709 6709
=======================================
Hits 17591 17591
Misses 408 408
Partials 558 558 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator decision (#hold-crucial-on-reject): a guarded/crucial PR (CI, review engine, visual) is never auto-closed, even on a reject — a hallucinated reject (the #1528 diff-only false-positive near-miss) must not auto-close a good crucial PR. Owner verifies + closes/merges. The bulk (non-guarded) still auto-closes on reject; only the small crucial set is held. Restores the guardrail check on
willClose(reverts #1106). Full suite green.