Skip to content

feat(signals): flag issues whose body only restates the title - #1445

Merged
JSONbored merged 2 commits into
JSONbored:mainfrom
jason020818:feat/issue-slop-restated-1782465597
Jun 28, 2026
Merged

feat(signals): flag issues whose body only restates the title#1445
JSONbored merged 2 commits into
JSONbored:mainfrom
jason020818:feat/issue-slop-restated-1782465597

Conversation

@jason020818

Copy link
Copy Markdown
Contributor

What

Adds a third deterministic issue-slop triage signal (#533) next to the existing empty-body and unfilled-template findings: title_only_restatement fires when a non-empty issue body normalizes to exactly the title — the submitter pasted the title back as the description and added nothing.

Why

The issue-side triage in buildIssueSlopAssessment catches an empty body and an unfilled template, but a body that merely restates the title slips through as clean today even though it carries no more information than the title alone. This is a common low-effort pattern the advisory triage should surface.

How / precision

  • Normalizes both sides case- and punctuation-insensitively (collapsing every non-alphanumeric run to a single space), so reformatting or added punctuation cannot dodge it.
  • Conservative by construction: the body must reduce to the title with zero extra words, so any genuine added detail (steps, location, expected vs actual) clears it.
  • The three issue signals stay mutually exclusive — restatement only evaluates once empty-body and unfilled-template are ruled out, since it needs a body with real prose.
  • Advisory-only, exactly like the sibling signals (issues never block). Static public-safe finding text, no interpolation.

Full branch coverage on every added line; rubric markdown and weights updated in lockstep.

@jason020818
jason020818 requested a review from JSONbored as a code owner June 26, 2026 09:31
@dosubot dosubot Bot added the size:M label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.51%. Comparing base (bd59608) to head (8663673).
⚠️ Report is 36 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1445   +/-   ##
=======================================
  Coverage   95.50%   95.51%           
=======================================
  Files         204      204           
  Lines       22018    22029   +11     
  Branches     7957     7965    +8     
=======================================
+ Hits        21029    21040   +11     
  Misses        413      413           
  Partials      576      576           
Files with missing lines Coverage Δ
src/signals/slop.ts 98.08% <100.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb

loopover-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review — safe to merge

2 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · clean

✅ Approved — safe to merge

Review summary
Adds a well-scoped third deterministic issue-triage signal: `title_only_restatement` fires when a non-empty body normalizes via Unicode-aware `/[^\p{L}\p{N}]+/gu` stripping to exactly the title. The mutual-exclusivity chain is correctly ordered — restatement only evaluates after both emptier signals are ruled out — and the `slopRisk` arithmetic correctly adds the new weight. Tests drive both the orchestrator path (`buildIssueSlopAssessment`) and the builder in isolation with thorough null-branch coverage. `validate` and `lint` are failing on this commit for a cause not visible in the diff and must be resolved before merge.

Signal Result Evidence
Code review ✅ No blockers 1 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:M.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 24 open PR(s), 10 likely reviewable, 14 unlinked.
Contributor context ✅ Confirmed Gittensor contributor jaso0n0818; Gittensor profile; 1169 PR(s), 7 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 5 non-blocking
  • The four-line comment block above `normalizeIssueText` restates what the regex already expresses — trim to one line or drop it; `src/signals/slop.ts` (`normalizeIssueText`).
  • The `(feat(github-app): issue-side slop triage #533)` ticket reference inside the JSDoc comment on `buildTitleRestatementIssueFinding` belongs in git history, not the function body, where it becomes a stale unresolvable pointer for future readers; `src/signals/slop.ts`.
  • Confirm whether `ISSUE_SLOP_WEIGHTS` or `ISSUE_SLOP_RUBRIC_MARKDOWN` feed any auto-generated or validated artifact (OpenAPI spec, focus-manifest snapshot, weight registry) that must be regenerated on change — a stale generated file is a plausible explanation for the failing `validate` check.
  • The pre-existing comment 'An empty body and an unfilled template are mutually exclusive' now describes only two of three mutually exclusive signals — either fold it with the new comment into one block that names all three, or accept the asymmetry; `src/signals/slop.ts` (`buildIssueSlopAssessment`).
  • Add a test for a body that is a strict word-subset of the title — e.g. `{ title: 'Login is broken today', body: 'login is broken' }` — to document that the signal is exact-match-only and does not fire on partial overlap; `test/unit/slop.test.ts`.
Review context
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Review details

Generated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative.

Adds a well-scoped third deterministic issue-triage signal: `title_only_restatement` fires when a non-empty body normalizes via Unicode-aware `/[^\p{L}\p{N}]+/gu` stripping to exactly the title. The mutual-exclusivity chain is correctly ordered — restatement only evaluates after both emptier signals are ruled out — and the `slopRisk` arithmetic correctly adds the new weight. Tests drive both the orchestrator path (`buildIssueSlopAssessment`) and the builder in isolation with thorough null-branch coverage. `validate` and `lint` are failing on this commit for a cause not visible in the diff and must be resolved before merge.

Nits (5)

  • The four-line comment block above `normalizeIssueText` restates what the regex already expresses — trim to one line or drop it; `src/signals/slop.ts` (`normalizeIssueText`).
  • The `(feat(github-app): issue-side slop triage #533)` ticket reference inside the JSDoc comment on `buildTitleRestatementIssueFinding` belongs in git history, not the function body, where it becomes a stale unresolvable pointer for future readers; `src/signals/slop.ts`.
  • Confirm whether `ISSUE_SLOP_WEIGHTS` or `ISSUE_SLOP_RUBRIC_MARKDOWN` feed any auto-generated or validated artifact (OpenAPI spec, focus-manifest snapshot, weight registry) that must be regenerated on change — a stale generated file is a plausible explanation for the failing `validate` check.
  • The pre-existing comment 'An empty body and an unfilled template are mutually exclusive' now describes only two of three mutually exclusive signals — either fold it with the new comment into one block that names all three, or accept the asymmetry; `src/signals/slop.ts` (`buildIssueSlopAssessment`).
  • Add a test for a body that is a strict word-subset of the title — e.g. `{ title: 'Login is broken today', body: 'login is broken' }` — to document that the signal is exact-match-only and does not fire on partial overlap; `test/unit/slop.test.ts`.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added gittensor gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jun 27, 2026
Add a third deterministic issue-slop signal (JSONbored#533) alongside the empty-body
and unfilled-template findings: `title_only_restatement` fires when a
non-empty issue body normalizes to exactly the title, i.e. the submitter
pasted the title back as the description and added nothing.

Conservative and high-precision, matching the issue-triage rubric: the body
must reduce to the title with zero extra words after case- and
punctuation-insensitive normalization, so any genuine added detail (steps,
location, expected vs actual) clears it. The three issue signals stay mutually
exclusive — restatement only evaluates once empty-body and unfilled-template
are ruled out, since it requires a body with real prose.
@jason020818
jason020818 force-pushed the feat/issue-slop-restated-1782465597 branch from 1284cfa to 04884ed Compare June 27, 2026 02:37
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. labels Jun 28, 2026
@dosubot dosubot Bot added the lgtm label Jun 28, 2026
@JSONbored
JSONbored merged commit 886f6af into JSONbored:main Jun 28, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants