test(selfhost): cover the null-value branch of the fs blob store put - #1491
Merged
Conversation
#1490 merged with a failing codecov/patch (admin override): the value ?? "" null arm of createFsBlobStore.put was untested. Add a null-value put test so the blob store is back to 100% branch coverage.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
=======================================
Coverage 95.44% 95.45%
=======================================
Files 195 195
Lines 21111 21111
Branches 7632 7632
=======================================
+ Hits 20150 20151 +1
Misses 383 383
+ Partials 578 577 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1490, which merged with a failing
codecov/patch(the admin override let it through): thevalue ?? ""null-value arm ofcreateFsBlobStore.putwas untested. Adds a null-value put test, restoring the blob store to 100% branch coverage. No production change.