Skip to content

fix(enrichment): detect quoted workflow uses keys - #1542

Merged
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-yaml-uses-key-bypass
Jun 27, 2026
Merged

fix(enrichment): detect quoted workflow uses keys#1542
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-yaml-uses-key-bypass

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • The unpinned-action analyzer used a line regex that required an unquoted literal uses: token and failed to detect valid YAML variants like uses : or quoted keys, allowing bypasses of the unpinned-action check.

Description

  • Relax the USES_RE to accept optional key quotes and optional whitespace before the colon so YAML-equivalent uses, uses :, "uses":, and 'uses' : forms are detected (review-enrichment/src/analyzers/actions-pin.ts).
  • Add a regression test exercising uses :, "uses":, and 'uses' : forms to ensure detection and line-citing remain correct (review-enrichment/test/enrichment.test.ts).

Testing

  • Ran the review-enrichment unit suite with npm --prefix review-enrichment test, which passed all tests.
  • Attempted the full local gate via git diff --check && npm run test:ci; earlier checks completed but the test:coverage stage hung in this environment and the run was terminated (partial progress observed before termination).
  • Ran npm audit --audit-level=moderate, which failed due to the npm registry audit endpoint returning 403 Forbidden in this environment.

Codex Task

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jun 26, 2026
@JSONbored JSONbored added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 26, 2026
@loopover-orb

loopover-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review — safe to merge

2 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · blocked

✅ Approved — safe to merge

Signal Result Evidence
Code review ✅ No blockers 1 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:XS.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 48 open PR(s), 9 likely reviewable, 39 unlinked.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 81 PR(s), 261 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 2 non-blocking
  • Repository config was not parsed
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 81 PR(s), 261 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (PR #1535)
  • Related work: Titles/paths share 6 meaningful terms. (PR #1537)
  • Related work: Titles/paths share 6 meaningful terms. (PR #1546)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@JSONbored
JSONbored merged commit f54d5d0 into main Jun 27, 2026
15 checks passed
@JSONbored
JSONbored deleted the codex/propose-fix-for-yaml-uses-key-bypass branch June 27, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant