feat(bounties): classify lifecycle advisory states - #157
Closed
Adamchaua wants to merge 2 commits into
Closed
Conversation
JSONbored
requested changes
Jun 1, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@Adamchaua Thanks for the update. This still needs another pass before review can move forward.
A few notes:
- The lifecycle split itself is a reasonable direction: separating
active,historical,stale,ambiguous, andunknowngives the advisory more useful maintainer signal than the old active/historical binary. - The linked-PR extraction is also directionally useful, especially because bounty context should account for already-attached work before treating something as open opportunity.
- The branch is not mergeable right now. It conflicts with current
maininsrc/signals/engine.tsandtest/unit/signals.test.ts. - CI is also failing in
test/unit/data-quality.test.tsandtest/unit/queue.test.ts, so this needs to be rebased and validated against the current data-quality/fidelity behavior before the bounty advisory logic can be reviewed cleanly.
Required changes:
- Rebase onto current
mainand resolve the signal test conflicts. - Re-run the full validate path after the rebase.
- Keep the lifecycle tests deterministic; avoid any date-sensitive assertions that can start failing as the 90-day boundary moves.
Expected validation:
npm run typechecknpm run test:coverage
JSONbored
requested changes
Jun 3, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@Adamchaua this needs a full rebase and validation pass before review can continue.
A few notes:
- The lifecycle states are a useful addition for bounty advisory quality.
- The branch conflicts in the signal engine and signal tests.
- Validate still fails across data-quality and queue expectations.
Required changes:
- Rebase on current
mainand resolve the signal conflicts. - Update the PR body to the current template.
- Re-run the full validation gate after the rebase.
Validation expected:
- Focused bounty/signal tests
- Full validate pipeline
Owner
|
Closing this as it's now stale, please resubmit / focus on updated features if interested in trying again. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Work Completed
Closes #23
Implemented a focused bounty lifecycle advisory improvement so Gittensory can distinguish active bounty context from stale or ambiguous bounty data before contributors act on it.
🔍 Requirement Match
activefor explicit active/open/funded states.stalewith a warning finding.ambiguousinstead of being treated as active.linkedPrsand a dedicated advisory finding when discoverable.💻 Changes Included
BountyAdvisory.lifecyclewithstaleandambiguousstates.linkedPrsto bounty advisories.🧪 Verification
npm test -- --run test/unit/signals.test.ts-> 18 tests passed.npm run typecheck-> passed.git diff --check-> passed.🎯 Notes
This PR is intentionally scoped to the existing bounty advisory surface and unit coverage. It does not add new ingestion jobs or public payout language.