fix(observability): redact Sentry log summaries - #1662
Conversation
9e78e5e to
b238503
Compare
b238503 to
4aa1254
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 204 204
Lines 22295 22303 +8
Branches 8053 8059 +6
=======================================
+ Hits 21310 21318 +8
Misses 408 408
Partials 577 577
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge Review summary
Nits — 4 non-blocking
Review context
Contributor next steps
Signal definitions
Review detailsGenerated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative. The change narrows field-only Sentry title summaries by skipping secret-keyed top-level fields and redacting secret-keyed nested values before JSON serialization. The implementation is correct for the described title-summary path, and the added tests cover scalar, nested array/object, and depth-cap behavior through the production forwarding function. The most notable remaining risk is that explicit `message`/`error` strings are still promoted unchanged, but that is outside the field-summary path this PR changes. Nits (4)
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 6323086 | Commit Preview URL Branch Preview URL |
Jun 28 2026, 09:50 PM |
Summary
No issue because this is maintainer-side confidentiality hardening for structured Sentry log forwarding. Field-only error logs should keep useful context in the issue title without promoting token/password/key-like fields into Sentry titles or notifications.
What changed
Validation
npx vitest run test/unit/selfhost-sentry.test.tsnpm run typecheckgit diff --checknpm audit --audit-level=moderatenpm run test:ci