fix(scoring): report issue close-window drift

[JSONbored]

Motivation

• Restore reporting of MAX_ISSUE_CLOSE_WINDOW_DAYS as an unmodeled upstream constant because it controls linked-issue close-window eligibility and was mistakenly excluded, which hid a real scoring-model gap.

Description

• Remove MAX_ISSUE_CLOSE_WINDOW_DAYS from NON_SCORING_UPSTREAM_CONSTANT_NAMES in src/scoring/model.ts so the constant surfaces in unmodeled-drift detection.
• Update the unit test in test/unit/scoring.test.ts to assert that MAX_ISSUE_CLOSE_WINDOW_DAYS is reported by findUnmodeledUpstreamConstants while DEFAULT_PROGRAMMING_LANGUAGE_WEIGHT remains ignored.

Testing

• Ran npx vitest run test/unit/scoring.test.ts -t "close-window", which passed (1 passed, 73 skipped).
• Ran npm run typecheck (tsc --noEmit), which passed.
• Attempted npm run test:ci and npm audit --audit-level=moderate, but those could not be completed locally due to environment/network limitations (actionlint setup retries / npm audit 403), so the full CI gate was not run here.

---

Codex Task

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.58%. Comparing base (6228967) to head (3128aea).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1725   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         204      204           
  Lines       22314    22314           
  Branches     8066     8066           
=======================================
  Hits        21329    21329           
  Misses        408      408           
  Partials      577      577           

Files with missing lines	Coverage Δ
src/scoring/model.ts	98.11% <ø> (ø)

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-06-29 18:36:20 UTC}

2 files · 1 AI reviewer · no blockers · readiness 68/100 · CI green · clean

⏸️ Suggested Action - Manual Review

• Touches a guarded path — held for manual review

Review summary
The change narrows `NON_SCORING_UPSTREAM_CONSTANT_NAMES` so `MAX_ISSUE_CLOSE_WINDOW_DAYS` is reported by `findUnmodeledUpstreamConstants`, while keeping `DEFAULT_PROGRAMMING_LANGUAGE_WEIGHT` ignored as loader metadata. The updated unit test exercises both the single-gap case and ordering alongside another unmodeled constant, matching the current sorted-key implementation. This is a small, coherent fix and the post-change file content supports the intended behavior.

Nits — 2 non-blocking

• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
• Touches a guarded path — held for manual review — A maintainer must review and merge this change.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	⚠️ Missing	No linked issue or no-issue rationale found.
Related work	⚠️ 2 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 2 registered-repo PR(s), 2 merged, 280 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	JSONbored; Gittensor profile; 2 PR(s), 280 issue(s).
Gate result	⚠️ Not blocking	Advisory; not blocking this PR.

Review context

• Author: JSONbored
• Role context: owner (maintainer lane)
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 2 PR(s), 280 issue(s).
• Related work: Titles/paths share 8 meaningful terms. (PR #1679, PR #1690)
• Related work: Titles/paths share 6 meaningful terms. (PR #1693, PR #1716)

Contributor next steps

• Treat this as maintainer-lane context rather than normal contributor-lane activity.
• Explain no-issue PR.
• Review top overlaps.
• Add a concise scope and risk note.
• Triage stale or unlinked PRs.
• No action.
• Link the issue being solved, or explicitly explain why this is a no-issue PR.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review